fix(redaction): fully redact whitespace-separated auth credentials#37
Merged
Merged
Conversation
Signed-off-by: JSONbored <49853598+JSONbored@users.noreply.github.com>
ed91865 to
6c0822d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
redact_textstopped assignment redaction at the first whitespace, which left credential tokens in values likeAuthorization: Basic <credential>unredacted and leaked into report evidence.Description
redact_textto allow an optional second whitespace-delimited token so two-part auth schemes (e.g.,Basic <credential>) are fully consumed and redacted.Bearerand known token shapes) and preserved surrounding context behavior (so unrelated trailing text like paths remain visible).redacts_basic_auth_values_after_sensitive_keysto ensureAuthorization: Basic ...values are fully redacted.Testing
cargo test -p nightward-core redacts_, and the redaction-related tests passed (6 passed; 0 failed).redacts_basic_auth_values_after_sensitive_keyswas executed as part of that run and passed.Codex Task