Add CI workflows and coverage #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+11
to
+19
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| targets: thumbv7em-none-eabihf | ||
| - name: Build firmware | ||
| run: cargo build -p firmware --release --target=thumbv7em-none-eabihf |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the issue, add a permissions block at the root of the workflow file. This block will explicitly define the minimal permissions required for the workflow. Since the workflow only checks out the repository and builds the firmware, it likely only needs contents: read permission. This ensures that the GITHUB_TOKEN has the least privilege necessary to perform the workflow tasks.
The permissions block should be added immediately after the name field in the workflow file to apply to all jobs in the workflow.
Suggested changeset
1
.github/workflows/firmware.yml
| @@ -1,2 +1,4 @@ | ||
| name: Firmware Build | ||
| permissions: | ||
| contents: read | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmtTesting
cargo fmt --all -- --checkcargo clippy -p keyboard-core -p simulatorcargo test -p keyboard-core -p simulatorhttps://chatgpt.com/codex/tasks/task_e_687ff1fde2f0832d9582e1ff926f602f