Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mod sign error #1586

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix mod sign error #1586

merged 1 commit into from
Dec 12, 2024

Conversation

sj-hub9796
Copy link
Contributor

@qyl27
Copy link
Collaborator

qyl27 commented Dec 12, 2024

Thanks a lot.

@qyl27 qyl27 merged commit 483ab31 into IzzelAliz:Trials Dec 12, 2024
@AdriianFdz
Copy link

Hi, the SecurityCraft mod signs are getting broken at the same way. Could you make a hotfix of that? Thanks!

image

@sj-hub9796
Copy link
Contributor Author

sj-hub9796 commented Dec 21, 2024

Hi, the SecurityCraft mod signs are getting broken at the same way. Could you make a hotfix of that? Thanks!

r u sure you did update to new version?
try delete .arclight directory and launch the server again

@AdriianFdz
Copy link

Tryed deleting .arclight but still the same bug. Im using arclight-forge-1.20.1-1.0.6-SNAPSHOT

The vanilla signs are working perfectly

@sj-hub9796
Copy link
Contributor Author

Tryed deleting .arclight but still the same bug. Im using arclight-forge-1.20.1-1.0.6-SNAPSHOT

The vanilla signs are working perfectly

https://github.com/IzzelAliz/Arclight/actions/runs/12326781537/artifacts/2320483745

u need to try this version.
delete .arclight directory and try again

thx

@AdriianFdz
Copy link

I´ve tryed that version.
However, I reinstalled and installed that version again, deleting .arclight. Same bug.
The security craft sign seems to be placed, but the error continues appearing in console.
No errors when are vanilla signs.
Thanks for the fast responses :)

@sj-hub9796
Copy link
Contributor Author

I´ve tryed that version. However, I reinstalled and installed that version again, deleting .arclight. Same bug. The security craft sign seems to be placed, but the error continues appearing in console. No errors when are vanilla signs. Thanks for the fast responses :)

hmm, can you try other mods sign?

@AdriianFdz
Copy link

AdriianFdz commented Dec 21, 2024

Hi again,

Farmers Delight signs (hanging) are throwing the same exception. The mod doesnt have "normal" signs

@sj-hub9796
Copy link
Contributor Author

Hi again,

Farmers Delight signs (hanging) are throwing the same exception. The mod doesnt have "normal" signs

Minecraft_.Forge.1.20.1.-.Multiplayer.3rd-party.Server.2024-12-22.06-07-41.mp4

well, works fine for me

@AdriianFdz
Copy link

well, and no errors in console? I can place them too, but console get spammed with that error. Not sure why...

@sj-hub9796
Copy link
Contributor Author

I´ve tryed that version. However, I reinstalled and installed that version again, deleting .arclight. Same bug. The security craft sign seems to be placed, but the error continues appearing in console. No errors when are vanilla signs. Thanks for the fast responses :)

well, if you have protocollib or ItemsAdder like something in your plugins, that's normal

@AdriianFdz
Copy link

Ye, I have protocolib. Any fix? or just removing that plugin

@sj-hub9796
Copy link
Contributor Author

Ye, I have protocolib. Any fix? or just removing that plugin

i mean, you can't place that sign?
or sign gui doesn't appear

@AdriianFdz
Copy link

I can place it and it seems to work everything, but im afraid that the console error makes my server crash cause it drops the exception everytime I place each sign

@sj-hub9796
Copy link
Contributor Author

sj-hub9796 commented Dec 22, 2024

I can place it and it seems to work everything, but im afraid that the console error makes my server crash cause it drops the exception everytime I place each sign

no, it won't crash. that's fine.
what is your protocollib version?
try /version ProtocolLib

@AdriianFdz
Copy link

Good.
ProtocolLib version 5.3.0

@sj-hub9796
Copy link
Contributor Author

Reference

hmm, try downgrade if you can.

@AdriianFdz
Copy link

I get crashes at login when I downgrade version. Seems that FastLogin requires 5.3.0 version, cause 5.2.0 don´t allow me to login into the server. IDK if you have any specific version to try.

@sj-hub9796
Copy link
Contributor Author

sj-hub9796 commented Dec 23, 2024

I get crashes at login when I downgrade version. Seems that FastLogin requires 5.3.0 version, cause 5.2.0 don´t allow me to login into the server. IDK if you have any specific version to try.

um, then just use 5.3.0.
and if the exception bother you, try this plugin: https://www.spigotmc.org/resources/console-spam-fix.18410/
also can you send me full logs?

@AdriianFdz
Copy link

All right, thanks.
Here you have the logs. Exception shows at [23Dec2024 12:23:40.421]

2024-12-23-2.log

@sj-hub9796
Copy link
Contributor Author

All right, thanks. Here you have the logs. Exception shows at [23Dec2024 12:23:40.421]

2024-12-23-2.log

oof, sry for late.
it wasn't Protocollib issue. it was CoreProtect.

@AdriianFdz
Copy link

AdriianFdz commented Dec 28, 2024

Oh no problem, these are tricky dates.

All right, so if anyone knows any way to fix it apart from hiding them through external plugin, would be great ^^

sj-hub9796 added a commit to sj-hub9796/Arclight that referenced this pull request Jan 31, 2025
qyl27 pushed a commit that referenced this pull request Feb 1, 2025
* implement missed bukkit things

* migrate to Decorate

* fix crash

* bring #1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants