MOB-11663-InApp-Calculations #949
Conversation
Needs reduction in code. Lot of repition. Heavy review and testing needed. Committing as inapps are looking stable and are sticking with the layout with back to back phone rotations when inapp performance would fail usually
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private String messageId; | ||
|
|
||
| // Resize debouncing fields | ||
| private Handler resizeHandler = new Handler(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| lastOrientation = currentOrientation; | ||
|
|
||
| // Use longer delay for orientation changes to allow layout to stabilize | ||
| final Handler handler = new Handler(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Ayyanchira
force-pushed
the
MOB-11663-InApp-Calculations
branch
from
2cc8a75 to
8e15c0a
Compare
iterableapi/src/androidTest/java/com/iterable/iterableapi/IterableApiResponseTest.java
Show resolved
Hide resolved
| if (loaded && webView != null) { | ||
| // Only trigger on significant orientation changes (90 degree increments) | ||
| int currentOrientation = ((orientation + 45) / 90) * 90; | ||
| if (currentOrientation != lastOrientation && lastOrientation != -1) { | ||
| lastOrientation = currentOrientation; | ||
|
|
||
| // Use longer delay for orientation changes to allow layout to stabilize |
There was a problem hiding this comment.
This allows for resize script to be called only limted number of times. This method when implemented, felt it was only called when landscape to portrait rotation was made. Hence explicit conditioning is required.
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Show resolved
Hide resolved
And removed unnecessary logging
Ayyanchira
force-pushed
the
MOB-11663-InApp-Calculations
branch
from
54b0276 to
e85d78a
Compare
|
@Ayyanchira Hmm lets have a chat about these. It seems we have made too many changes related to In app screen size for this release and i want to see them all in one place somehow. Also wondering if a smaller diff will solve the problem. cc @davidtruong |
Needs reduction in code. Lot of repition. Heavy review and testing needed. Committing as inapps are looking stable and are sticking with the layout with back to back phone rotations when inapp performance would fail usually
🔹 Jira Ticket(s) if any
✏️ Description