Lastfm update #268
Open
Lastfm update #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added update now playing function and implemented scrobble conditions according to https://www.last.fm/de/api/scrobbling
(you also could scrobble on track end, but I often skip the end of a track so I chose the half duration or 4min condition)
Related to: #230
You wrote "upgrade the last.fm library to a modern one" in your icebox..
I looked around but all lib's I've found are changed over 1year ago.. so there is no "modern one"?
I you have an idea which lib you would use in future just give me a link and I try to include this.
PS: sry for the long commit history.. I just getting used to github