Skip to content

optimize unregister pollerEvent in macos platform #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
overtalk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

optimize unregister pollerEvent in macos platform #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c411c
optimize unregister pollerEvent in macos platform
overtalk May 15, 2020
4a86f35
fix bug
overtalk May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions include/brynet/net/TcpConnection.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,14 +945,14 @@ namespace brynet { namespace net {
struct epoll_event ev = { 0, { nullptr } };
epoll_ctl(mEventLoop->getEpollHandle(), EPOLL_CTL_DEL, mSocket->getFD(), &ev);
#elif defined BRYNET_PLATFORM_DARWIN
struct kevent ev[2];
memset(&ev, 0, sizeof(ev));
int n = 0;
EV_SET(&ev[n++], mSocket->getFD(), EVFILT_READ, EV_DELETE, 0, 0, NULL);
EV_SET(&ev[n++], mSocket->getFD(), EVFILT_WRITE, EV_DELETE, 0, 0, NULL);

struct timespec now = { 0, 0 };
kevent(mEventLoop->getKqueueHandle(), ev, n, NULL, 0, &now);
// struct kevent ev[2];
// memset(&ev, 0, sizeof(ev));
// int n = 0;
// EV_SET(&ev[n++], mSocket->getFD(), EVFILT_READ, EV_DELETE, 0, 0, NULL);
// EV_SET(&ev[n++], mSocket->getFD(), EVFILT_WRITE, EV_DELETE, 0, 0, NULL);

// struct timespec now = { 0, 0 };
// kevent(mEventLoop->getKqueueHandle(), ev, n, NULL, 0, &now);
#endif
}
#endif
Expand Down