Skip to content

lab-list-comprehesion #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarabenitezinglott
Copy link

No description provided.

@sh-ih
Copy link

sh-ih commented Oct 16, 2023

Sara,
Good job on this lab. But there is a issue throughout your solutions: you created set comprehensions, not list comprehensions, by using curly brackets { } instead of square brackets [ ]

Although it may seem like it is not relevant, because you got the results, each data type has it’s own characteristics, and it can lead to bugs if you think you are working with a list and in reality you created a set.

I recommend you that you modify this lab to be list comprehensions (just change the {} for []) so it can work as an accurate future reference for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants