Skip to content

Setup upgrade 1.6.3: Set all langs to lowercase #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sudwebdesign
Copy link
Collaborator

Description

Setup upgrade language's of database to lowercase

Motivation and Context

Solve a problem if language folders changed to lowercase

Why? see discussion of PR #1230

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix (if language folders are lowercase)
  • Improvement of an existing Feature
  • New Feature

@sudwebdesign
Copy link
Collaborator Author

sudwebdesign commented Feb 7, 2025

Only if next version have the language folders become lowercase

Because previous versions (<= v1.6.2) language set with UCfirst in database and need upgrade

Need to be verified in reality (update by setup not launched)

@sudwebdesign sudwebdesign mentioned this pull request Feb 7, 2025
Get an error like:
Unable to load the requested language file: language/French/ip_lang.php

Reason:
When user are logged in before call & complete setup,
On next login, session return old params.

Need destroy session to be set by new params from database
(Here for langs)
@sudwebdesign
Copy link
Collaborator Author

Model checked & verified, all languages in db (user & settings) become to lowercase after update applied.

But after setup completed and login, old session data are not modified, Fixed by this push ;)

Note:

This is probably what happened with #1148

Fun fact:

If in next version the language folder become to lowercase, the lists (in selectors) become to good order and English as in good place (not at end)

@nielsdrost7 nielsdrost7 changed the base branch from development to development-v163 May 19, 2025 08:39
@nielsdrost7 nielsdrost7 merged commit aa59269 into InvoicePlane:development-v163 May 19, 2025
1 check passed
nielsdrost7 added a commit that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants