fix(cli): reject unlinked umbrella blockers - #60
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements BRIX-1537 by making same-umbrella dependencies follow the same V1 rule as normal Linear dependencies: incomplete blockers must resolve to an existing Quay task before the dependent subtask can be enqueued.
Behavior
merged_to_feature_branch.dependency_not_trackedbefore task/worktree/artifact/dependency side effects.Spec Check
This matches the spec requirement that incomplete Linear blockers resolve to existing Quay tasks and that V1 must not create unresolved dependency rows.
Tests
bun test packages/cli/tests/cli/enqueue_linear_issue.test.tsbun test packages/cli/tests/core/task_dependencies.test.ts packages/cli/tests/tick/tick_001_promotes_queued_to_running.test.ts packages/cli/tests/pr/test_053_pr_open_merged_transitions_terminal.test.tsbun run scripts/embed.tsbun run typecheck:cli