[issues-93] - WildFly + remote Infinispan distributed timers test#94
Open
fabiobrz wants to merge 1 commit intoIntersmash:mainfrom
Open
[issues-93] - WildFly + remote Infinispan distributed timers test#94fabiobrz wants to merge 1 commit intoIntersmash:mainfrom
fabiobrz wants to merge 1 commit intoIntersmash:mainfrom
Conversation
fabiobrz
changed the title
tommaso-borgato
requested changes
Mar 27, 2026
|
|
||
| // Set the build input | ||
| buildInput = new BuildInputBuilder() | ||
| // TODO: fix before merging!!! We have two aplications and 2 PRs for this test, but just one property |
Collaborator
There was a problem hiding this comment.
@fabiobrz this is just a thread to remind ourselves to replace this
| environmentVariables.add( | ||
| new EnvVarBuilder() | ||
| .withName("POSTGRESQL_DATABASE") | ||
| .withValue("theData") |
Collaborator
There was a problem hiding this comment.
@fabiobrz these user, password and database config:
environmentVariables.add(
new EnvVarBuilder()
.withName("POSTGRESQL_DATABASE")
.withValue("theData")
.build());
environmentVariables.add(
new EnvVarBuilder()
.withName("POSTGRESQL_USER")
.withValue("theUser")
.build());
environmentVariables.add(
new EnvVarBuilder()
.withName("POSTGRESQL_PASSWORD")
.withValue("thePassword")
.build());should come from some constant value in PostgresqlTimerExpirationStoreApplication:
parameters.put("POSTGRESQL_USER", "theUser");
parameters.put("POSTGRESQL_PASSWORD", "thePassword");
parameters.put("POSTGRESQL_DATABASE", "theData");--> I suggest adding constants in PostgresqlTimerExpirationStoreApplication and referencing them in WildFlyTimerExpirationStoreApplication
| .statusCode(HttpStatus.SC_OK); | ||
| } | ||
|
|
||
| private void cancelTimer(final String applicationInfo) { |
Collaborator
There was a problem hiding this comment.
@fabiobrz just a suggestion: looks like the two cancleTimer functions have a lot in common and might perhaps further refactored:
|
|
||
| private void giveTheTimerEnoughTimeToExecuteOnce(final Long waitInterval, final String applicationInfo) { | ||
| SimpleWaiter waiter = new SimpleWaiter( | ||
| () -> retrieveExpirations(applicationInfo).size() > 0, |
Collaborator
There was a problem hiding this comment.
@fabiobrz perhaps we can use !retrieveExpirations(applicationInfo).isEmpty() here
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the WildFly + Infinispan distributed timers tests.
Resolves #93, and relates to:
Type of change
test, version modification, documentation, etc.)
Checklist