fix the logic of closing session

[lvhan028]

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

1. Pre-commit or other linting tools are used to fix the potential lint issues.
2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
4. The documentation has been modified accordingly, like docstring or example tutorials.

[Copilot]

Pull request overview

This PR addresses issues with session closing logic in the lmdeploy session manager and includes additional CMake build configuration improvements. The main focus is on fixing how sessions are closed to prevent premature cancellation and ensure proper resource cleanup when the main program exits.

Changes:

• Enhanced the Session.close() method to wait for async operations to complete with a 5-second timeout
• Added early exit optimization for sessions that haven't processed any requests yet
• Improved error logging in async_close() to use logger.exception()
• Wrapped test executables in BUILD_TEST conditionals in two CMakeLists.txt files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
lmdeploy/serve/managers/session_manager.py	Main fix: Added synchronization to close() method to wait for async operations, early return for unused sessions, and improved error logging
src/turbomind/kernels/CMakeLists.txt	Wrapped test_quantization executable in BUILD_TEST conditional
src/turbomind/comm/gloo/CMakeLists.txt	Wrapped test_ipc_comm executable in BUILD_TEST conditional

Comments suppressed due to low confidence (1)

lmdeploy/serve/managers/session_manager.py:128

• The abort() method doesn't wait for the async operation to complete, unlike the new close() implementation. This inconsistency could lead to race conditions where abort() returns before the async_abort() coroutine finishes executing. While the async_abort() method has a comment indicating "DO NOT reset the session here because it might be used by other components," the lack of synchronization in abort() could still cause issues if the caller expects the abort operation to complete before proceeding.

Consider applying similar synchronization logic to abort() as was added to close(), or document why abort() doesn't need to wait for completion while close() does.

    def abort(self):
        """Abort the session in sync mode."""
        self._run(self.async_abort())

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.