Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix duplicate name when same block used twice in one town
Potential fix for #2237. This code was removed by #2100. However, it's necessary to edit then store a *copy* of block data for each block to have a unique name seed from MAPS.BSA, even when starting from same RMB data. If data is modified in same instance of RMB data then second time block data is read it effectively overwrites first. @df-ferital Please let me know if this causes any problems with your RMB caching. I'm not sure why this removed and I didn't catch this outcome in my review of your RMB caching PR. Thank you! :)
- Loading branch information
a42ca59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this mistake on my side! While working on blocks caching, I think I deleted those lines at some point to check the effect in-game and probably did not notice any in the towns I tested. But now that you put the code back, I understand why they are required and this shouldn't affect caching at all.
a42ca59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Ferital! :) I was hoping it would be that simple and cause any problems for your changes. Thanks for checking and getting back to me.