Skip to content

Conversation

@SirYwell
Copy link
Member

Overview

Fixes #3387

Description

There are 2 problems here:

  1. Without the Confirm annotation, we never check if the selection is present. The changed commands all work on regions and should therefore also properly handle confirmation.
  2. Our custom binding returns null instead of throwing IncompleteRegionException. I didn't find any reason for this binding to exist, so I think removing it make the most sense.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner November 30, 2025 18:10
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//line <block> without selection gives exception

4 participants