This repository was archived by the owner on Jan 26, 2026. It is now read-only.
Better initialization for wave and shallow water benchmarks#19
Merged
Conversation
Collaborator
tkarna
commented
Nov 7, 2024
tkarna
commented
- Replace fromfunction in initialization by reshape and permute_dims
- Exclude JIT compilation time from timing. This is consistent with other benchmarks.
tkarna
force-pushed
the
bye-bye-fromfunction
branch
from
32d491c to
aba4ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.