Permit building mkl_fft with Python 3.13
#164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
requested review from
vtavana,
antonwolfy,
xaleryb and
ekomarova
as code owners
Add 3.13 builds to clang workflow
vtavana
force-pushed
the
permit-build-python-3.13
branch
from
c38b8ca to
d41c971
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables Python 3.13 support across the project’s packaging and CI workflows.
- Adds Python 3.13 classifier and updates
requires-pythonrange inpyproject.toml. - Documents Python 3.13 support in
CHANGELOG.md. - Extends GitHub Actions matrices to include Python 3.13 in conda and pip builds.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added 3.13 classifier and bumped requires-python to <3.14 |
| CHANGELOG.md | Added [dev] entry for Python 3.13 support |
| .github/workflows/conda-package.yml | Included Python 3.13 in the conda packaging matrix |
| .github/workflows/conda-package-cf.yml | Included Python 3.13 and corresponding NumPy versions |
| .github/workflows/build_pip.yaml | Added Python 3.13 matrix and setuptools install |
| .github/workflows/build-with-clang.yml | Included Python 3.13 in clang build matrix |
Comments suppressed due to low confidence (2)
CHANGELOG.md:7
- Replace the placeholder date 'YYYY-MM-DD' with the actual release or update date to keep the changelog accurate.
## [dev] - YYYY-MM-DD
.github/workflows/conda-package.yml:23
- [nitpick] The Python version list is duplicated across multiple workflow files; consider defining it once (e.g., via a YAML anchor or reusable strategy) to reduce duplication and risk of inconsistency.
python: ['3.9', '3.10', '3.11', '3.12', '3.13']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add python 3.13 builds to workflows