Skip to content

Update third party tests since support of shape=None was dropped in numpy 2.3 #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2025
Merged

Update third party tests since support of shape=None was dropped in numpy 2.3 #2484

merged 2 commits into from
Jun 19, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 18, 2025 •
edited
Loading

The PR updates third party tests, since numpy 2.3 dropped support of passing shape=None to functions with a non-optional shape argument errors.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 18, 2025
@antonwolfy antonwolfy self-assigned this Jun 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_18 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2025 •
edited
Loading

Coverage Status

coverage: 71.863%. remained the same
when pulling 7a4e9ed on shape-none-prohibited-in-numpy-2.3
into 0d01250 on master.

@antonwolfy antonwolfy marked this pull request as ready for review June 18, 2025 13:45
@antonwolfy antonwolfy merged commit aec9934 into master Jun 19, 2025
70 of 72 checks passed
@antonwolfy antonwolfy deleted the shape-none-prohibited-in-numpy-2.3 branch June 19, 2025 07:41
github-actions bot added a commit that referenced this pull request Jun 19, 2025
@github-actions
Update third party tests since support of shape=None was dropped in…
640c3a2 
… numpy 2.3 (#2484)

The PR updates third party tests, since numpy 2.3
[dropped](https://numpy.org/devdocs/release/2.3.0-notes.html#expired-deprecations)
support of passing `shape=None` to functions with a non-optional shape
argument errors. aec9934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana