[F812] Warn when list comprehension redefines a name #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lint rule is probably in Flake8 to prevent elements from leaking out of the comprehension scope, but the behavior was fixed in Python3. I worry such a strict lint rule will cause more problems than it solves, considering we use Python 3.10 at Meta. Perhaps we should consider disabling this rule by default. [ghstack-poisoned]
This was referenced Mar 8, 2023
facebook-github-bot
added
the
CLA Signed
This lint rule is probably in Flake8 to prevent elements from leaking out of the comprehension scope, but the behavior was fixed in Python3. I worry such a strict lint rule will cause more problems than it solves, considering we use Python 3.10 at Meta. Perhaps we should consider disabling this rule by default. [ghstack-poisoned]
amyreese
requested changes
Mar 17, 2023
Collaborator
amyreese
left a comment
amyreese
left a comment
There was a problem hiding this comment.
Can you add some test cases covering mutually exclusive scopes, where I would expect this to be allowed?
Something like:
def foo():
i = 1
print(i)
def bar():
values = [i * 2 for i in range(5)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
pyflakesdirectory #271This lint rule is probably in Flake8 to prevent elements from leaking
out of the comprehension scope, but the behavior was fixed in Python3.
I worry such a strict lint rule will cause more problems than it solves,
considering we use Python 3.10 at Meta. Perhaps we should consider
disabling this rule by default.