Skip to content

Test rules in pyflakes directory #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/"ansley"/1/base
Choose a base branch
from
Open

Test rules in pyflakes directory #271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18213fa
Test rules in `pyflakes` directory
ansley Mar 8, 2023
440528a
Update on "Test rules in `pyflakes` directory"
ansley Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ version-file = "src/fixit/__version__.py"
features = ["dev", "pretty"]

[tool.hatch.envs.default.scripts]
test = "python -m fixit.tests"
test = "python3 -m fixit.tests"
Copy link
Collaborator

@amyreese amyreese Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change needed? Hatch environments should be controlled enough that just python will always work.

Copy link
Author

@ansley ansley Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, didn't know that

Copy link
Collaborator

@amyreese amyreese Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this being "python3" is what's causing the CI failures on windows. My guess is that the virtualenv doesn't have a python3.exe in it, and so it's finding a random non-venv runtime, and therefore can't find/import fixit.

typecheck = "mypy --install-types --non-interactive src/fixit"

[tool.hatch.envs.lint.scripts]
Expand Down
4 changes: 4 additions & 0 deletions src/fixit/tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@
globals(),
collect_rules(enables=[QualifiedRule("fixit.rules")], disables=[]),
)
add_lint_rule_tests_to_module(
globals(),
collect_rules(enables=[QualifiedRule("fixit.rules.pyflakes")], disables=[]),
)