Updated plugin to support array with paths instead of single path #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kmohamed
reviewed
Jul 8, 2019
| if single_path != nil | ||
| curlCommand += build_single_file_command(command, single_path) | ||
| else | ||
| dsym_paths = params[:dsym_array_paths].uniq |
There was a problem hiding this comment.
First thanks a lot for your contributions🙏. But I have a single question why you did not add then in a zip file and upload it once instead of upload each file separately.
Author
There was a problem hiding this comment.
To be honest I didn't thought about that 😂 but even if I did, I wouldn't be sure if that even works. Because I'm also not a ruby developer I tried to achieve the result with minimum effort, which was for me do the pipe for calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
download_dsymsfastlane plugin returns an array of paths I had to update the plugin to be able to parse that array and upload each of file separately