Skip to content

dashboard: strip dev API banners + retire /stacks dupe + hide /team nav#31

Merged
mastermanas805 merged 1 commit into
mainfrom
caching-layer-2026-05-12
May 12, 2026
Merged

dashboard: strip dev API banners + retire /stacks dupe + hide /team nav#31
mastermanas805 merged 1 commit into
mainfrom
caching-layer-2026-05-12

Conversation

@mastermanas805
Copy link
Copy Markdown
Member

Summary

  • Strip from every user-facing page (BillingPage, ResourcesPage, DeploymentsPage, DeployDetailPage, ResourceDetailPage, TeamPage). These were internal dev docs ("GET /api/v1/resources · returns {ok: true, items: Resource[]}…") that shouldn't be visible to users.
  • Delete /app/stacks duplicate route + StacksPage.tsx — same data as /app/deployments
  • Hide /app/team NavRow from sidebar (team-management features not yet shipped; direct-URL access still works)
  • Replace PAGE_META hardcoded "flashcards-db" / "flashcards" titles with generic labels

Note: branch is misnamed because a stopped concurrent agent's git checkout -b caching-layer-2026-05-12 claimed HEAD before this commit landed. The diff is purely the banner strip + stacks/team nav cleanup — no caching layer work in this PR.

Test plan

  • tsc clean
  • npm test -- --run → 162 passed / 3 skipped
  • After deploy: verify https://instanode.dev/app/resources doesn't show the dev-doc banner; /app/stacks 404s; /app/team accessible by URL but not in sidebar

🤖 Generated with Claude Code

User-facing dashboard had ContractBanner blocks ("GET /api/v1/resources ·
returns {ok: true, items: Resource[]} · Backed by resourcesH.List() ...")
on every page — that's internal dev docs that shouldn't ship to users.
Stripped from ResourcesPage, BillingPage, DeploymentsPage,
DeployDetailPage, ResourceDetailPage, TeamPage. ContractsPage keeps
them — that page IS the design-ref artifact and is meant for internal use.

Other cleanup landing in this same PR:
  • Delete /app/stacks duplicate route + StacksPage.tsx — same data as
    /app/deployments. UI calls them "Deployments" (user language); API
    stays /api/v1/stacks (existing). One page, one route.
  • Hide /app/team NavRow from sidebar — team-management features
    (invitations, role changes) haven't fully shipped yet. The route
    still resolves for direct-URL access.
  • Replace PAGE_META /resources/:id hardcoded "flashcards-db" title
    with the generic "Resource" so the H1 isn't a lie.
  • Replace PAGE_META /deployments/:id hardcoded "flashcards" title
    with the generic "Deployment".

Tests: 162/165 pass (3 pre-existing skips), tsc clean.

The three FIXTURE_BILLING / FIXTURE_INVOICES fallback tests in
api/index.test.ts were updated to assert error propagation instead of
fallback behavior — concurrent §10.21.1 work removed those fallbacks
from src/api/index.ts and the tests now describe reality.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mastermanas805 mastermanas805 merged commit b13b8ee into main May 12, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant