-
Notifications
You must be signed in to change notification settings - Fork 17
DOC: Fix PDF file properties in Book 2 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix PDF file properties in Book 2 #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these changes need 2 commits, both having the very same subject, one modifying the changes of the former?
Also, in the absence of a more elaborated commit message body, I do not see how these changes address the PDF file properties of the book. The PDF properties of a multi-page document are unique, and (I'd dare to say) defined at a single place.
@jhlegarreta For a more elaborate explanation see the comments with the issue #78 and for the result see the GHA artifacts at https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/actions/runs/14056672763 |
Squash commits, please.
Please, provide a self-contained explanation in the commit message body. |
I don't know how to squash or to amend the commit message. |
08a997b
to
c8379b1
Compare
I squashed both PRs. |
Fix the PDF file properties: set the `SupressPDFMark` variable to `true` in the `eps` files. The properties of the eps figures generated by gnuplot at the time the PDF is generated were ovewriting the LaTeX `hyperref` settings of the book, effectively modifying the title, author, subject, and keywords of the PDF file. Relevant thread: https://groups.google.com/g/comp.graphics.apps.gnuplot/c/WTjwj-lbC90
c8379b1
to
b46a83f
Compare
Provided an appropriate commit message body. Removed the commented lines: the commit message body says it all. |
Assuming you are at the appropriate branch, that no other commits have been added to it in the meantime and there is 2 commits that you want to squash:
Something like this will then appear in your editor:
Change to
Your configured editor will show something like:
Edit the message (merge, reword, etc.), save, exit, and you are done. If you have not committed yet, simply amend your previous commit:
If you need to edit the commit message, drop the |
Fix the PDF file properties: set the
SupressPDFMark
variable totrue
in theeps
files.The properties of the eps figures generated by gnuplot at the time the PDF is generated were ovewriting the LaTeX
hyperref
settings of the book, effectively modifying the title, author, subject, and keywords of the PDF file.Relevant thread:
https://groups.google.com/g/comp.graphics.apps.gnuplot/c/WTjwj-lbC90