Skip to content

DOC: Fix PDF file properties in Book 2 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

albert-github
Copy link
Contributor

@albert-github albert-github commented Mar 24, 2025

Fix the PDF file properties: set the SupressPDFMark variable to true in the eps files.

The properties of the eps figures generated by gnuplot at the time the PDF is generated were ovewriting the LaTeX hyperref settings of the book, effectively modifying the title, author, subject, and keywords of the PDF file.

Relevant thread:
https://groups.google.com/g/comp.graphics.apps.gnuplot/c/WTjwj-lbC90

@albert-github albert-github marked this pull request as draft March 24, 2025 17:26
@github-actions github-actions bot added type:Artwork Changes to artwork files type:Documentation Documentation improvement or change labels Mar 24, 2025
@dzenanz dzenanz requested a review from jhlegarreta March 24, 2025 17:39
@albert-github albert-github marked this pull request as ready for review March 25, 2025 12:54
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these changes need 2 commits, both having the very same subject, one modifying the changes of the former?

Also, in the absence of a more elaborated commit message body, I do not see how these changes address the PDF file properties of the book. The PDF properties of a multi-page document are unique, and (I'd dare to say) defined at a single place.

@albert-github
Copy link
Contributor Author

@jhlegarreta
The first commit unfortunately had an error (the / was missing).

For a more elaborate explanation see the comments with the issue #78 and for the result see the GHA artifacts at https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/actions/runs/14056672763

@jhlegarreta
Copy link
Member

@jhlegarreta
The first commit unfortunately had an error (the / was missing).

Squash commits, please.

For a more elaborate explanation see the comments with the issue #78 and for the result see the GHA artifacts at https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/actions/runs/14056672763

Please, provide a self-contained explanation in the commit message body.

@albert-github
Copy link
Contributor Author

I don't know how to squash or to amend the commit message.
@dzenanz can you have a look at it?

@dzenanz
Copy link
Member

dzenanz commented Mar 25, 2025

I squashed both PRs.

Fix the PDF file properties: set the `SupressPDFMark` variable to `true`
in the `eps` files.

The properties of the eps figures generated by gnuplot at the time the
PDF is generated were ovewriting the LaTeX `hyperref` settings of the
book, effectively modifying the title, author, subject, and keywords of
the PDF file.

Relevant thread:
https://groups.google.com/g/comp.graphics.apps.gnuplot/c/WTjwj-lbC90
@jhlegarreta
Copy link
Member

Provided an appropriate commit message body. Removed the commented lines: the commit message body says it all.

@jhlegarreta
Copy link
Member

jhlegarreta commented Mar 25, 2025

I don't know how to squash or to amend the commit message.

Assuming you are at the appropriate branch, that no other commits have been added to it in the meantime and there is 2 commits that you want to squash:

$ git rebase -i HEAD~2

Something like this will then appear in your editor:

pick hash1 Commit1_message_subject
pick hash2 Commit2_message_subject

Change to

pick hash1 Commit1_message_subject
s hash2 Commit2_message_subject

Your configured editor will show something like:

# This is a combination of 2 commits.
# This is the 1st commit message:

(...)

# This is the commit message #2:

(...)

Edit the message (merge, reword, etc.), save, exit, and you are done.

If you have not committed yet, simply amend your previous commit:

$ git commit --amend --no-edit

If you need to edit the commit message, drop the ---no-edit part.

@dzenanz dzenanz merged commit 96450bf into InsightSoftwareConsortium:main Mar 28, 2025
3 checks passed
@albert-github albert-github deleted the feature/issue_78 branch March 28, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Artwork Changes to artwork files type:Documentation Documentation improvement or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants