STYLE: Let SobelOperator::Fill use IndexRange, allowing ND support
#5723
+19
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same code for 2D and 3D to pave the way to support ND, as requested by issue InsightSoftwareConsortium#5702 "A ND Sobel implementation is needed"
github-actions
bot
added
area:Core
dzenanz
approved these changes
Jan 8, 2026
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Looks good on a glance. Ideally someone else should review too.
hjmjohnson
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same code for 2D and 3D to pave the way to support ND, as requested by issue #5702 "A ND Sobel implementation is needed"
SobelOperator::Filluse ImageRange, allowing ND support #5722