Skip to content

STYLE: Address code review nitpicks - fix comments and formatting

ee6aa99
Select commit
Loading
Failed to load commit list.
Draft

ENH: Implement PEP 688 buffer protocol for ITK Python #5673

STYLE: Address code review nitpicks - fix comments and formatting
ee6aa99
Select commit
Loading
Failed to load commit list.
kwrobot-v1 / ghostflow-check-main failed Dec 5, 2025 in 0s

ghostflow-check-main

overall branch status for the content checks against main

Branch-at: ee6aa99

Details

Errors:

  • commit f9a351d cannot be merged; it must start with one of the following prefixes: BUG: , COMP: , DOC: , ENH: , PERF: , STYLE: .

  • commit fb74ad2 adds bad whitespace:

    Modules/Core/Common/wrapping/test/itkImageTest.py:65: new blank line at EOF.
    
  • commit 4583a85 adds bad whitespace:

    Wrapping/Generators/Python/PyBase/pyBase.i:705: trailing whitespace.
    +              
    Wrapping/Generators/Python/PyBase/pyBase.i:710: trailing whitespace.
    +              
    
  • commit ba8abd5 adds bad whitespace:

    Wrapping/Generators/Python/PyBase/pyBase.i:722: trailing whitespace.
    +              
    Wrapping/Generators/Python/PyBase/pyBase.i:733: trailing whitespace.
    +              
    
  • commit e757c93 adds bad whitespace:

    Modules/Bridge/NumPy/include/itkPyBuffer.hxx:81: trailing whitespace.
    +  
    Modules/Bridge/NumPy/include/itkPyBuffer.hxx:87: trailing whitespace.
    +  
    Wrapping/Generators/Python/PyBase/pyBase.i:688: trailing whitespace.
    +              
    

Warnings:

  • the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.