Skip to content

ENH: Enable Adobe Deflate Option for TIFF compression #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ENH: Enable Adobe Deflate Option for TIFF compression #5352

wants to merge 1 commit into from

Conversation

blowekamp
Copy link
Member

Enables addressing the following warning:
TIFFWriteDirectorySec: Warning, Creating TIFF with legacy Deflate codec identifier, COMPRESSION_ADOBE_DEFLATE is more widely supported.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp
ENH: Enable Adobe Deflate Option for TIFF compression
fb23b2d 
Enables addressing the following warning:
TIFFWriteDirectorySec: Warning, Creating TIFF with legacy Deflate codec identifier, COMPRESSION_ADOBE_DEFLATE is more widely supported.
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation area:IO Issues affecting the IO module labels May 15, 2025
dzenanz
dzenanz approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the user needs to invoke SetCompressionToAdobeDeflate() for this PR to have any effect?

@blowekamp
Copy link
Member Author

It does not change the old behavior of setting the compressor to deflate. The other way to set is with ImageIOBase::SetCompressor()

@blowekamp
Copy link
Member Author

/azp run ITK.Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:IO Issues affecting the IO module type:Enhancement Improvement of existing methods or implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blowekamp @dzenanz