Fix Eisek (and probably other NPCs) showing up as winged dragon-boy #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisek (and probably other NPCs) showed up as 'The winged dragon-boy' because getFleshSubspecies() always returned 'HUMAN' for him for whatever reason. I've adjusted the code to only check for getFleshsubspecies() if the BodyMaterial is not flesh and for getSubspecies() otherwise. Did a few tests with Eisek, my occupants and some slimes including the ones in the Slime Queen's Tower and everything works as intended so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request?
Fixed Eisek (and probably other named NPCs) showing up as 'The winged dragon-boy'.
Give a brief description of what you changed or added.
Eisek (and probably other NPCs) showed up as 'The winged dragon-boy' because getFleshSubspecies() always returned 'HUMAN' for him for whatever reason. I've adjusted the code to only check for getFleshsubspecies() if the BodyMaterial is not flesh and for getSubspecies() otherwise.
Did a few tests with Eisek, my occupants and some slimes including the ones in the Slime Queen's Tower and everything works as intended so far.
Are any new graphical assets required?
No
Has this change been tested? If so, mention the version number that the test was based on.
Yes, 0.4.10.7 Alpha
So we have a better idea of who you are, what is your Discord Handle?
Stadler#3007