Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major update #3

Merged
merged 60 commits into from
Mar 10, 2024
Merged

Next major update #3

merged 60 commits into from
Mar 10, 2024

Conversation

Baptouuuu
Copy link
Member

@Baptouuuu Baptouuuu commented Jan 25, 2024

Why

The goal of this refactoring is to use a more monadic approach to consuming the socket. This is done by using stream Frames to allow to decouple what is expected coming through the socket from when it is actually read.

This is a playground to be able to declare in a pure fashion a socket protocol. If this is successful, this approach will be generalised to other Innmind packages.

What

  • The connection mutable nature is now expressed by returning SideEffects instead of returning a copy of the connection object
  • The protocol is declared via innmind/io Frames meaning it's decoupled from the runtime
  • The connection socket is now used via the innmind/io wrapper so it's more declarative
  • When reading the messages the body is now a temporary file Content

Note

This refactoring allows to use this package inside innmind/mantle asynchronous context safely.

@Baptouuuu Baptouuuu self-assigned this Jan 25, 2024
@Baptouuuu Baptouuuu marked this pull request as draft January 25, 2024 13:41
Copy link

codecov bot commented Mar 7, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Baptouuuu Baptouuuu marked this pull request as ready for review March 10, 2024 13:29
@Baptouuuu Baptouuuu merged commit a6e3865 into develop Mar 10, 2024
9 checks passed
@Baptouuuu Baptouuuu deleted the next branch March 10, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant