Repository navigation
Keep the narrow toolbar and the menu usable on short boards - #2
Merged
Merged
Conversation
On narrow boards the bottom toolbar scrolls sideways. Its tooltips hung below the buttons, so it could be scrolled up and down as well and the buttons slid out of view. The toolbar now hides its tooltips there and scrolls sideways only. The main menu had no height limit, so on a short board its last items ran under the bottom toolbar. It now scrolls within the board, and on narrow boards it opens above the toolbar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two layout problems on narrow, short boards, found while using the board on a phone.
Toolbar scrolled vertically
On narrow boards (
@container rwb (max-width: 720px)) the toolbar getsoverflow-x: autoso the tools can scroll sideways, which also makes it scrollable vertically. Its tooltips are positioned below the buttons (.rwb-tip-bottom) and made the content 28px taller than the toolbar, so a vertical swipe moved the buttons out of view.overflow-y: hidden,overscroll-behavior-x: containandtouch-action: pan-x.Menu ran under the toolbar
.rwb-menuhad no height limit. On a short board its last items (Clear canvas) went past the bottom edge and, on narrow boards, under the toolbar, which sits above it..rwb-menugetsmax-height: calc(100cqh - 72px)(it opens 60px below the top edge; the root is already a size container) and scrolls when it does not fit..rwb-top-leftgoes fromz-index: 3to4, so an open menu is drawn above the toolbar.Wide boards are unchanged apart from the menu's height limit, which only matters on boards shorter than the menu.
Release
Bumps the version to 1.1.1 with a changelog entry.
Checks
format:check,lint,typecheck,testand both builds pass.