fix(kotlin): propagate exceptions properly on failed parsing #783
+44
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This seems sane, but this definitely warrants a test to make sure there's no future regression |
Contributor
Author
|
Added the test |
Citymonstret
force-pushed
the
fix-coroutines-parser
branch
from
18a3316 to
d15d07e
Compare
Citymonstret
changed the title
Citymonstret
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser annotation javadoc guarantees that exceptions thrown by the method will be wrapped into a failure. Currently on enabling coroutines support this behavior disappears, exceptions being propagated to an internal exception.
This pr fixed this by wrapping parser exceptions into failures.