feat: subagent prompting and /finished command #14
Conversation
Summary of ChangesHello @IgorWarzocha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the workflow for subagent sessions by enabling direct user interaction within them and introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new /finished command for subagent sessions, which is a great addition for managing subtasks. The implementation enables prompting in subagent TUI sessions and correctly handles injecting the summary back into the parent session. The code is generally well-structured. However, I've identified a copy-paste error in one of the files where a command registration block is duplicated, which should be removed.
|
/opencode review this. suggest changes |
Co-authored-by: IgorWarzocha <[email protected]>
|
Changes made:
These changes ensure:
|
Expand AGENTS.md with comprehensive coding and operational protocols. Implement logic to terminate subagent sessions and notify parents, while preventing the removal of primary sessions.
Replace the 'kill' command with 'wipe' to remove an idle subagent session. Add 'wipeout' to remove all idle subagent sessions at once. Delete obsolete agent and command definitions in .opencode.
- replace existing /kill with /wipe (idle subagents only, no parent notification) - add /wipeout to delete all idle child sessions from parent - fix race condition by navigating before deletion in TUI - update app.tsx to navigate to parent session on deletion - improve autocomplete logic to prevent duplicate commands and handle session status
|
/oc verify core opencode functionality is still intact. removal of /unshare was a bit weird. assess implementation of /wipe and /wipeout. analyse the edge cases it might introduce. |
Analysis Report
|
|
/gemini summary |
Summary of ChangesThis pull request significantly enhances the user experience and management capabilities for subagent sessions within the TUI. It introduces direct user prompting in subagent contexts, alongside new commands to streamline the completion and termination of subtasks. These changes aim to improve the efficiency of multi-agent workflows and provide clearer communication between subagents and parent sessions, while also updating internal development guidelines and cleaning up old configuration files. Highlights
Changelog
Activity
|
parentIDvisibility restriction, enabling more fluid user interaction with subagents./finishedCommand: A new built-in command,/finished, has been introduced for subsessions. Executing this command triggers an immediate summary generation within the subagent, which is then automatically injected as a new prompt into the parent session, notifying the user of task completion./wipeand/wipeout, have been added./wipeallows for the termination and removal of an idle subagent session, while/wipeoutenables the termination of all idle subagent sessions from a parent session, both with appropriate navigation and user feedback.config.updatedandskill.updatedevents, ensuring that agents, commands, and configuration data are automatically refreshed when changes occur, improving system reactivity. (unsure why this is here tbh)