Experiment with a different test file design, single file with all mappings#14
Open
spectranaut wants to merge 2 commits intoacacia-test-testdriverfrom
Open
Experiment with a different test file design, single file with all mappings#14spectranaut wants to merge 2 commits intoacacia-test-testdriverfrom
spectranaut wants to merge 2 commits intoacacia-test-testdriverfrom
Conversation
spectranaut
commented
Aug 15, 2024
| "blockquote" | ||
| ] | ||
| ] | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
These are the objects that are currently being used in the manual tests, the directory above this one:
https://github.com/web-platform-tests/wpt/blob/master/core-aam/blockquote-manual.html
We could have an entry for every role in the role mapping tables of core-aam. Then, when a role from a different AAM points to core-aam, you can use the same map here. Currently the keys are the id refs for the mapping table, such as: https://w3c.github.io/core-aam/#role-map-blockquote
spectranaut
commented
Aug 15, 2024
core-aam/acacia/JSON-blockquote.html
Outdated
| let result = await test_driver.test_accessibility_api_node('test', | ||
| rolemap['role-map-blockquote'] | ||
| ); | ||
| assert_equals(result, "match", "role=blockquote"); |
Collaborator
Author
There was a problem hiding this comment.
This is a little awkward, result is either an error message containing all the statements that were incorrect, or, the string "match"
af6e66f to
d98a6ef
Compare
d98a6ef to
89cadf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using the
core-aam/acacia/json/as a temporary directory for these tests.These tests use js object that contains an entry for each table in core-aam. So the tests are very simple:
Here is the result of this test: https://spectranaut.github.io/examples/wpt/role_blockquote_test.html
Right now the test has one subtest for each API, regardless of whether or not that API applies to platform the test is being run on. The test was run on linux, so only the first test -- the test of the linux API
Atspi-- is useful. The other tests aren't actually run (because you can't run a mac accessibility API test on linux), which you can see by expanding and seeingNo assertions run. If you are curious about this design, read more in this other PR's description