Add Collection for dynamic Forms

[TAINCER]

This aims to add support for dynamic Form Fields. The API is still WIP, up to date examples can be found in CollectionTest.php.

Simple Example:

        $collection = new Collection('testCollection');

        $collection->setAddElement('add_element', [
            'required' => false,
            'label'    => 'Add Trigger',
            'options'  => [null => 'Please choose', 'first' => 'First Option'],
            'class'    => 'autosubmit'
        ]);

        $collection->onAssembleGroup(function ($group, $addElement, $removeElement) {
            $group->addElement($addElement);

            $group->addElement('input', 'test_input');
        });

        $form
            ->registerElement($collection)
            ->addHtml($collection)

depends on

• Replace SubFormElement with FieldsetElement #74

[lippserd]

• Please always use single quotes for strings that don't require interpolation. This helps to distinguish strings that actually require it.
• Use heredoc/nowdoc for expected HTML.
• Always add a newline at the end of files. PHPStorm has a setting for this. Also, PHPStorm can automatically remove spaces at the end of lines.
• I would go with the following API:
  • setTriggerElement() instead of setAddTrigger().
  • setRemoveElement() instead of setRemoveTrigger().
  • onTrigger() instead of on(Collection::ON_LOAD, ...).
• Remove events as they become obsolete with the above changes.

[lippserd]

Please use the following:

        $this
            ->assembleGroup($group, $addElement ?? null, $removeElement ?? null)
            ->addElement($group);

Else the decorate() call is missing.

[TAINCER]

With addElememt() the items added from assembleGroup are no longer added. I tried adding ->decorate($group) before the addHtml call, and the output was the same in my test cases, also in the Unit Tests.

[lippserd]

Could this be just $this->addGroup($key ? ($key + 1): 0);?

[TAINCER]

The problem is getting the last key in the first place. Since this is not the foreach anymore. Functionality wise this should act like array_key_last, which is only available in 7.3 and up.

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @lippserd, @TAINCER

Details

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @lippserd, @TAINCER

Details

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[bobapple]

@cla-bot check

[lippserd]

Please rebase with master and add proper class and method PHPDoc. Also example usage for the element would be nice.