Open
Conversation
5 tasks
Contributor
|
You have pushed some old commits, please cleanup. |
sukhwinder33445
previously approved these changes
Mar 3, 2026
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
1f65733 to
7bff6db
Compare
Add types to `FormElements::isValidEvent()` and `FormElement::addMessage()` for compatibility with ipl-stdlib.
Add types to `addDecoratorLoader()` and `addElementLoader()` and set the default value of `$postfix` to an empty string to be compatible with ipl-stdlib.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
7bff6db to
303a9c2
Compare
BastianLedererIcinga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust
FormElements::isValidEvent()andFormElement::addMessage()for compatibility with the modernized stdlib.requires: Icinga/ipl-stdlib#63 for tests to pass