Check if actual checkbox value equals checkedValue#144
Merged
Conversation
jrauh01
force-pushed
the
fix/required-checkbox-validation
branch
from
57b0b19 to
7b6f673
Compare
nilmerg
requested changes
Mar 24, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
One thing to note is that an unchecked checkbox is now not validated anymore. But a quick search didn't yield any usage of an validator for checkboxes…
But, there's a test for this element, please add one covering this change.
jrauh01
force-pushed
the
fix/required-checkbox-validation
branch
from
140400d to
7d1feea
Compare
nilmerg
approved these changes
Mar 24, 2025
nilmerg
requested changes
Mar 24, 2025
jrauh01
force-pushed
the
fix/required-checkbox-validation
branch
2 times, most recently
from
b8f1cdf to
1222b5e
Compare
Contributor
Author
|
@nilmerg I think the test should now test the case correctly. |
nilmerg
requested changes
Mar 25, 2025
jrauh01
force-pushed
the
fix/required-checkbox-validation
branch
from
1222b5e to
f37d36d
Compare
nilmerg
previously approved these changes
Mar 25, 2025
jrauh01
force-pushed
the
fix/required-checkbox-validation
branch
from
f37d36d to
e9eb991
Compare
nilmerg
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override method
hasValue()fromBaseFormElementinCheckboxElement.Fix #143