Fix zero-capacity disk rendering and root rule inheritance - #639
Merged
Conversation
Guest disk rendering divided by the reported capacity in both the row and footer percentage output. Automount entries can report a capacity of zero, which made the VM disk usage table fail while rendering. The usage bar had the same zero-total division when calculating its CSS width. Zero-capacity rows and totals now render n/a for the percentage and a zero-width usage bar.
Rule refresh can reach objects whose managed object has no parent UUID. The previous code passed that null value into listParentUuidsFor(), whose string parameter raises a TypeError on PHP 8 instead of loading inherited settings. Missing parent UUIDs now use the existing root rule-set sentinel, so root objects can still inherit global monitoring rules without entering parent traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts fixes from PRs #630, #631, and #632 into a clean branch without carrying over the mixed/stacked/incomplete changes.
capacity = 0.SimpleUsageBarwhen the total is zero.closes #630
closes #631
closes #632