Minor fixes to the Noise.c and Readme.md#35
Open
AlexT1983 wants to merge 4 commits intoITU-R-Study-Group-3:masterfrom
Open
Minor fixes to the Noise.c and Readme.md#35AlexT1983 wants to merge 4 commits intoITU-R-Study-Group-3:masterfrom
AlexT1983 wants to merge 4 commits intoITU-R-Study-Group-3:masterfrom
Conversation
I think max of two FamTl и FamTu is more correct
Fixed description of ITURNoise arguments
jhazentia
previously requested changes
Mar 31, 2025
| Argument 3 is a float that indicates the frequency (MHz). In the example above the frequency is 1.0 MHz. | ||
| Argument 4 is a float that indicates the latitude (degrees). In the example above the latitude desired is 40? N. | ||
| Argument 5 is a float that indicates the longitude (degrees). In the example above the longitude desired is 165? E | ||
| Argument 6 is a float that indicates the man-made noise which can either be categorical (0-5) or value of man-made noise in dB (represented by a negative number). In the example above the value 1.0 indicates that the noise category residential. The category codes appear below. |
Collaborator
There was a problem hiding this comment.
It looks like the argument numbers below need to be shifted. I think line number 869 should be referencing Argument 6. Line numbers 870 and 871 should be Argument 7 and Argument 8
ITURNoise() arguments 6,7,8 -> arguments 7,8,9
Collaborator
|
@RBallardNTIA Will you please resolve the merge conflicts? |
RBallardNTIA
approved these changes
May 15, 2025
Collaborator
|
@ErikHillNTIA I'm good if you are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Readme.md frequency argument of the ITURNoise description was omitted.
Also I think when we calculate FamT, we should choose maximum of FamTl and FamTu values as the worst-case noise.