feat(config): disable mail configuration for brand 'ionoscloud'#132
Merged
Arsalanulhaq merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Arsalanulhaq
force-pushed
the
as/feat/disable-mailconfig-when-brand-is-ionoscloud
branch
from
ae531f6 to
cd9c215
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent enabling the Nextcloud Mail “IONOS mailconfig” integration for the ionoscloud brand by adding brand-conditional logic to configure_ionos_mailconfig_api in configure.sh.
Changes:
- Adds a brand check intended to disable
mail ionos-mailconfig-enabledwhen the system is running under theionoscloudbrand. - Forces
ionos-mailconfig-enabledback tonowhen the brand condition matches.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
printminion-co
requested changes
Mar 10, 2026
Arsalanulhaq
force-pushed
the
as/feat/disable-mailconfig-when-brand-is-ionoscloud
branch
from
cd9c215 to
f32570d
Compare
printminion-co
requested changes
Mar 10, 2026
Arsalanulhaq
force-pushed
the
as/feat/disable-mailconfig-when-brand-is-ionoscloud
branch
from
f32570d to
000d353
Compare
Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
printminion-co
force-pushed
the
as/feat/disable-mailconfig-when-brand-is-ionoscloud
branch
from
000d353 to
9fc57d4
Compare
printminion-co
approved these changes
Mar 11, 2026
Arsalanulhaq
deleted the
as/feat/disable-mailconfig-when-brand-is-ionoscloud
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds logic to the
configure_ionos_mailconfig_apifunction inconfigure.shto conditionally disable the mail configuration based on the system brand. If the brand is set to "ionoscloud", the script will automatically disable theionos-mailconfig-enabledsetting.Brand-specific configuration:
brandsystem configuration; if it is "ionoscloud", the script disables theionos-mailconfig-enabledsetting to prevent mail configuration from being enabled for this brand.