Improve from_tuple method: add validation, error handling, and commen… #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Nitish89847 wants to merge 1 commit into INCF:master from Nitish89847:fix-from-tuple-comments

Nitish89847 commented Jul 24, 2025

Summary:

This PR improves the from_tuple() method in BasePortConnection to address Issue #35.

Changes:

Adds type and length checks for the input tuple
Improves exception messages for missing sender/receiver roles/names
Replaces assert False with NineMLUsageError for clarity
Adds inline comments to clarify logic

Related Issue

Fixes #35


          Improve from_tuple method: add validation, error handling, and commen…

d39a115

…ts (Fixes INCF#35)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet