Fix: Render HTML in dataset explorer long description#1206
Open
Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Open
Fix: Render HTML in dataset explorer long description#1206Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Conversation
Member
|
Thanks for your contribution here! I like this change. Did you happen to check if it passes a cycle of edit, save, and display again with embedded html? |
Author
|
Thanks for checking @jorvis! I looked at the code and line 625 in the same file covers the after-save update path as well, so both the initial render and the edit/display cycle should be handled. That said, I haven't been able to test it on a live instance, happy to update if you spot anything! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#1164
The long description field in the dataset explorer result card was using
.textContent, which renders HTML tags as plain text. Changed to.innerHTMLso descriptionswith embedded HTML are rendered correctly, consistent with how the Dataset Information dialog already handles it.