Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix after kinematics_interface API break (v1.1.0 -> v1.2.0) #46

Merged
merged 13 commits into from
Jan 18, 2025

Conversation

tpoignonec
Copy link
Member

@tpoignonec tpoignonec commented Nov 12, 2024

Fix after kinematics_interface API changes to support robot description (see issue #83 and PR #66).

Linked internal PRs that HAVE TO BE MERGED FIRST:

@tpoignonec tpoignonec changed the title Tpoignonec fix kinematics interface api break Fix after kinematics_interface API break (v1.1.0 -> v1.2.0) Nov 12, 2024
@tpoignonec tpoignonec linked an issue Nov 12, 2024 that may be closed by this pull request
@tpoignonec
Copy link
Member Author

Waiting for debian package update (stiil 1.1.0 at time of writing...)

Copy link

github-actions bot commented Nov 12, 2024

Test Results

662 tests   - 17   444 ✅  - 17   0s ⏱️ -1s
 36 suites  -  3   216 💤 ± 0 
 36 files    -  3     2 ❌ ± 0 

For more details on these failures, see this check.

Results for commit dc8282e. ± Comparison against base commit 3a0867d.

This pull request removes 17 tests.
dynamics_interface_fd.TestDynamicsFdPlugin ‑ FD_plugin_as_kinematics_interface_only
dynamics_interface_fd.TestDynamicsFdPlugin ‑ FD_plugin_function_std_vector
dynamics_interface_fd.TestDynamicsFdPlugin ‑ FD_plugin_function_with_omega3_urdf
dynamics_interface_fd.TestDynamicsFdPlugin ‑ FD_plugin_function_with_omega6_urdf
dynamics_interface_fd.TestDynamicsFdPlugin ‑ FD_plugin_no_robot_description
dynamics_interface_fd.TestDynamicsFdPlugin ‑ incorrect_input_sizes
dynamics_interface_fd.TestDynamicsFdPlugin ‑ no_inertia_published
dynamics_interface_kdl.TestKDLPlugin ‑ KDL_plugin_as_kinematics_interface_only
dynamics_interface_kdl.TestKDLPlugin ‑ KDL_plugin_function
dynamics_interface_kdl.TestKDLPlugin ‑ KDL_plugin_function_std_vector
…

♻️ This comment has been updated with latest results.

@tpoignonec
Copy link
Member Author

Remaining test error: cpplint_rosidl_typesupport_fastrtps_c.xunit.xml: 19 tests, 0 errors, 2 failures, 0 skipped

--> message too long probably, TBD later...

@tpoignonec tpoignonec merged commit 815b394 into main Jan 18, 2025
2 of 4 checks passed
@tpoignonec tpoignonec deleted the tpoignonec-fix_kinematics_interface_API_break branch January 18, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API breaking kinematics interface version (1.1.0 -> 1.2.0)
1 participant