Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #19

Merged
merged 4 commits into from
Mar 13, 2025
Merged

PHP 8.4 support #19

merged 4 commits into from
Mar 13, 2025

Conversation

andriuspetrauskis
Copy link
Contributor

This pull request adds ability to test code using PHP 8.4 images.

  • Switched from buster to bookworm as buster tags are not created for php 8.4.
  • Added 8.4 version to docker compose in addition to github workflow
  • Updated code and test deprecations

@coveralls
Copy link

coveralls commented Mar 13, 2025

Coverage Status

coverage: 97.22%. remained the same
when pulling ec69ddf on andriuspetrauskis:6.0
into afb5b3d on ICanBoogie:6.0.

@olvlvl
Copy link
Member

olvlvl commented Mar 13, 2025

Hi @andriuspetrauskis, thank you very much for your contribution. Could you have a look at the issues reported by PHPStan? https://github.com/ICanBoogie/CLDR/actions/runs/13824584341/job/38679425598?pr=19 I'm ready to merge once they are fixed.

@olvlvl olvlvl merged commit 4cb6742 into ICanBoogie:6.0 Mar 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants