-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixrule(element_orientation_unlocked, img_alt_valid, aria_accessiblename_exists, img_alt_null
): fix issues related to the rules
#2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunguoy
changed the title
fixrule(
fixrule(Aug 27, 2024
element_orientation_unlocked, img_alt_valid, aria_accessiblename_exists
): fix issues related to the ruleselement_orientation_unlocked, img_alt_valid, aria_accessiblename_exists, img_alt_null
): fix issues related to the rules
tombrunet
previously approved these changes
Aug 28, 2024
tombrunet
reviewed
Aug 28, 2024
tombrunet
approved these changes
Aug 28, 2024
@ErickRenteria Tom is OK with pushing out this PR, but @shunguoy |
Opening new issue against version of Puppeteer (used in automated ACT testing). v13 does not handle the CSS correctly while v20 does. This PR should proceed to QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
element_orientation_unlocked
marks failed test case #4 inapplicable #1958img_alt_null
for conflicts in attributes and map to ACT rule 46ca7f #2013Testing reference:
element_orientation_unlocked
marks failed test case #4 inapplicable #1958: test/v2/checker/accessibility/rules/element_orientation_unlocked_ruleunit/act-fail4.htmlimg_alt_null
for conflicts in attributes and map to ACT rule 46ca7f #2013: test/v2/checker/accessibility/rules/img_alt_null_ruleunit/Img-alt-arialabel.htmlI have conducted the following for this PR: