feat(consumer): return err from offsets commit #2635
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `ConsumerGroupSession` and `OffsetManager` interface in a way that’s compatible for users of these interfaces, but incompatible for implementers. Contributes-to: #2417 Signed-off-by: Joe Wreschnig <[email protected]>
Collaborator
Author
|
As noted that even our own internals fail due the errcheck linter on offsetManager.Commit, it probably makes sense to defer this to |
|
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. |
github-actions
bot
added
the
stale
dnwe
added
stale/exempt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
ConsumerGroupSessionandOffsetManagerinterface in a way that’s compatible for users of these interfaces, but incompatible for implementers.Contributes-to: #2417