chore(ci): remove unused linting-security-trufflehog make target#3874
Open
Lang-Akshay wants to merge 1 commit intomainfrom
Open
chore(ci): remove unused linting-security-trufflehog make target#3874Lang-Akshay wants to merge 1 commit intomainfrom
Lang-Akshay wants to merge 1 commit intomainfrom
Conversation
Remove the TruffleHog filesystem secret scanning make target and all associated references. Secret detection is already covered by Gitleaks for git history scanning and other tools in the CI pipeline. Removed: - linting-security-trufflehog make target and recipe - LINT_TRUFFLEHOG_TARGET and LINT_TRUFFLEHOG_VERSION variables - help comment and .PHONY declaration - TruffleHog references from SECURITY.md documentation Signed-off-by: Lang-Akshay <akshay.shinde26@ibm.com>
Lang-Akshay
requested review from
brian-hussey,
dima-zakharov,
ja8zyjits,
jonpspri and
lucarlig
lucarlig
approved these changes
Mar 26, 2026
Collaborator
lucarlig
left a comment
lucarlig
left a comment
There was a problem hiding this comment.
LGTM
rg -n "linting-security-trufflehog|trufflehog"returns no matches anywhere in the PR branch.make --no-print-directory helpno longer lists linting-security-trufflehog, while linting-security-checkov, linting-security-kube-linter, and linting-full still appear as expected.make --no-print-directory -n linting-full COMMITLINT_FROM=HEAD~1 COMMITLINT_TO=HEADsucceeds and expands to the expected remaining targets, with no dependency on TruffleHog.- .github/workflows/linting-full.yml only invokes make linting-full, so there’s no direct workflow dependency on the removed target.
crivetimihai
changed the title
crivetimihai
added
chore
Member
|
Thanks @Lang-Akshay. Clean removal of the dead trufflehog target — it was never functional since trufflehog isn't a project dependency. Please add the DCO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the TruffleHog filesystem secret scanning make target (
linting-security-trufflehog) and all associated references from the project.Changes
linting-security-trufflehogtarget recipe,.PHONYdeclaration, help comment,LINT_TRUFFLEHOG_TARGETandLINT_TRUFFLEHOG_VERSIONvariablesRationale
Secret detection is already covered by Gitleaks (git history scanning), Dodgy (hardcoded secrets in code), detect-private-key, and Snyk custom rules. TruffleHog adds redundant filesystem-level scanning that duplicates existing coverage.