feat: secret-error-fix: Updating the fix for secret-error-fix #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2025 18:44
Signed-off-by: Gayathri Alageswaran <[email protected]>
Signed-off-by: Gayathri Alageswaran <[email protected]>
Signed-off-by: Gayathri Alageswaran <[email protected]>
gayathri-alageswaran
force-pushed
the
secret-error-fix
branch
from
625459c to
7e018de
Compare
kevinkuhner
requested changes
Nov 14, 2025
Member
kevinkuhner
left a comment
kevinkuhner
left a comment
There was a problem hiding this comment.
@gayathri-alageswaran - please see my comments.
Signed-off-by: Gayathri Alageswaran <[email protected]>
kevinkuhner
approved these changes
Dec 4, 2025
Member
kevinkuhner
left a comment
kevinkuhner
left a comment
There was a problem hiding this comment.
Thank you @gayathri-alageswaran . Change looks fine to me. Would like @JasonHallman to also review.
JasonHallman
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
If any signing error is happening, here exception is catches but there is not proper error is responded back
SOLUTION:
While signing if any error is happening then enable the variable signing_error and based on this we are throwing the error.
@kevinkuhner , @raksharao13 Please Review and give the comments