Initial code to support TCF v2.3 (no yet ready for review) #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinzBaumann
changed the title
HeinzBaumann
changed the title
HeinzBaumann
changed the title
pgoforth
reviewed
Nov 25, 2025
Comment on lines
+101
to
+103
| if (segments.length >= 3) { | ||
| encodedSegments.push(segments[3].encode()); | ||
| } |
There was a problem hiding this comment.
Nit: Technically the ENUM value for VendorsDisclosed is 1 and PublisherPurposes is 3...so shouldn't the segments switch order? I know their first field indicates their segment type, and it doesn't REALLY matter, so I'm fine with just doing it this way. I mean, it's been in the wrong order for this long right?
pgoforth
reviewed
Nov 25, 2025
Comment on lines
+144
to
+148
| private updateDateStamp(): void { | ||
| const date = new Date(); | ||
| const utcDate = new Date(Date.UTC(date.getUTCFullYear(), date.getUTCMonth(), date.getUTCDate())); | ||
| super.setFieldValue(TcfEuV2Field.CREATED, utcDate); | ||
| super.setFieldValue(TcfEuV2Field.LAST_UPDATED, utcDate); |
There was a problem hiding this comment.
🎉 THANK YOU! Only using Year, Month, Date is the correct implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial code to support TCF 2.2
Initial code to support TCF 2.3