Update the README to reflect correct usage of the script #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinzBaumann
approved these changes
May 29, 2025
Collaborator
HeinzBaumann
left a comment
HeinzBaumann
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks
Author
|
@HeinzBaumann I don't think I have permission to merge, do you? |
NevilleS
approved these changes
May 30, 2025
NevilleS
left a comment
NevilleS
left a comment
There was a problem hiding this comment.
Thanks for this update @amanda-ruby; I tried this out on a toy project where I:
npm installthe@iabgpp/stubmodule- Add a single
gppStub.tsfile that just doesimport "@iabgpp/stub" - Bundle that into a
dist/gppStub.jsscript - Include with
<script src="dist/gppStub.js" />in an HTML page - Confirm the
__gppstub exists
Not having a default export like the docs indicate isn't a great dev experience (as described here: #59) but at least this README update makes the docs correct
chuff
approved these changes
Jun 26, 2025
uc-bsam
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPP stub script does not work as currently described in the README--it immediately runs upon import and does not have an importable function. I've updated the README to reflect this.