Fix AbstractLazilyEncodableSection.toObj to better match specs #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapo
changed the title
Contributor
|
@zapo why was this closed? It seems like the original issue hasn't been fixed. |
Author
|
@jameshartig Happy to reopen, mostly because I didn't get any feedback and the original issue didn't seem confirmed by maintainers |
lamrowena
added
investigate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #48
This fixes
AbstractLazilyEncodableSectionto build an array of segments as defined in https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Core/CMP%20API%20Specification.md#getsection- rather than a single object with all of its segments merged in.AbstractLazilyEncodableSection.toObjwhich is used to populateparsedSectionsand returned bygetSection*so this would be a breaking change.I'm happy to add tests for
GppModel.toObjectas it seems to be intended to representparsedSections.