Skip to content

private instance and parameterised generics#506

Open
oruuke wants to merge 1 commit into
HytaleModding:mainfrom
oruuke:patch-1
Open

private instance and parameterised generics#506
oruuke wants to merge 1 commit into
HytaleModding:mainfrom
oruuke:patch-1

Conversation

@oruuke
Copy link
Copy Markdown

@oruuke oruuke commented May 4, 2026

Pull Request

Description

changed instance to be private and generics to be parameterised

Type of Change

  • Documentation fix (typo, grammar, clarification)
  • New documentation (guide, tutorial, page)
  • Bug fix
  • New feature
  • Other

Screenshots

If applicable, add before/after screenshots:

Checklist

  • Tested locally with bun run dev
  • Formatted code to adhere Styleguide with bun format
  • Ran bun audit (no critical vulnerabilities)
  • Checked spelling and grammar
  • Verified all links work
  • Followed Contributing Guidelines

Thank you for contributing!

@oruuke oruuke requested a review from ItsNeil17 as a code owner May 4, 2026 09:50
@oskarscot
Copy link
Copy Markdown
Contributor

oskarscot commented May 4, 2026

Missing instance setter in constructor, get will throw a NPE

public ExamplePlugin(@Nonnull JavaPluginInit init) {
    super(init);
    instance = this;
    LOGGER.atInfo().log("Hello from " + this.getName() + " version " + this.getManifest().getVersion().toString());
}

Copy link
Copy Markdown
Member

@ItsNeil17 ItsNeil17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constructor missing as @oskarscot pointed out

@oruuke
Copy link
Copy Markdown
Author

oruuke commented May 9, 2026

dang it only noticed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants