private instance and parameterised generics#506
Open
oruuke wants to merge 1 commit into
Open
Conversation
ItsNeil17
approved these changes
May 4, 2026
Contributor
|
Missing instance setter in constructor, public ExamplePlugin(@Nonnull JavaPluginInit init) {
super(init);
instance = this;
LOGGER.atInfo().log("Hello from " + this.getName() + " version " + this.getManifest().getVersion().toString());
} |
ItsNeil17
requested changes
May 4, 2026
Member
ItsNeil17
left a comment
There was a problem hiding this comment.
Constructor missing as @oskarscot pointed out
Author
|
dang it only noticed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
changed instance to be private and generics to be parameterised
Type of Change
Screenshots
If applicable, add before/after screenshots:
Checklist
bun run devbun formatbun audit(no critical vulnerabilities)Thank you for contributing!