Fix missing org name (short and long) in email templates #4638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the signature of the application notification emails was off:
While investigating I found out that the
base.htmlemail template was usingorg_long_nameinstead ofORG_LONG_NAME(which is what theglobal_varscontext processor is providing).This issue appears to be widespread, and it's not helped by the fact that some emails correctly receive the
org_long_namevariable (it's passed manually in the context).For this PR, I went with the exhaustive approach of replacing every single instance of
org_long_name,org_short_name, andorg_emailwith their uppercase counterparts: