Skip to content

Conversation

@bmispelon
Copy link
Contributor

I noticed that the signature of the application notification emails was off:

Kind Regards,
The  Team

--

http://example.com

While investigating I found out that the base.html email template was using org_long_name instead of ORG_LONG_NAME (which is what the global_vars context processor is providing).
This issue appears to be widespread, and it's not helped by the fact that some emails correctly receive the org_long_name variable (it's passed manually in the context).

For this PR, I went with the exhaustive approach of replacing every single instance of org_long_name, org_short_name, and org_email with their uppercase counterparts:

git grep -lw org_long_name | xargs sed -i 's/\borg_long_name\b/ORG_LONG_NAME/'
git grep -lw org_short_name | xargs sed -i 's/\borg_short_name\b/ORG_SHORT_NAME/'
git grep -lw org_email | xargs sed -i 's/\borg_email\b/ORG_EMAIL/'

@bmispelon bmispelon marked this pull request as draft November 26, 2025 13:32
@bmispelon
Copy link
Contributor Author

bmispelon commented Nov 26, 2025

I just realized this breaks compilemessages because it introduces duplicate message definitions. Converting this PR to draft while I figure out how to fix that.

Edit: I ended up fixing the duplicate messages manually by opening the po files with poedit and letting it clean them up.

@bmispelon bmispelon marked this pull request as ready for review November 26, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant