Skip to content

Fix variable expansion#1568

Closed
RanMd wants to merge 4 commits intoHyDE-Project:devfrom
RanMd:fix-variable-expansion
Closed

Fix variable expansion#1568
RanMd wants to merge 4 commits intoHyDE-Project:devfrom
RanMd:fix-variable-expansion

Conversation

@RanMd
Copy link
Contributor

@RanMd RanMd commented Jan 21, 2026

Description

This PR is related to #1521.

Fix

Fixes variable expansion of $srcPath, in ~/.local/share/hyprland.conf

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Summary by CodeRabbit

  • Chores
    • Reorganized configuration file structure for improved maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

kRHYME7 and others added 3 commits January 14, 2026 18:37
This is an automated PR to promote changes from `dev` to `rc`.
Please review and test before merging.

See [TESTING.md](./TESTING.md) for complete testing instructions.

According to our release policy, this PR is expected to be merged
during: **Freeze Week (see release policy)**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* chore Merge branch 'rc' into dev (c79a476) by Khing
* docs: translate documentation to Portuguese (HyDE-Project#1543) (c7c6189) by
Khing
* chore Merge branch 'dev' into docs-ptbr (ded3b89) by Khing
* chore More waybar improvements for menus & tooltips (HyDE-Project#1549) (0fb2228)
by Khing
* feat: add fade animation for menus and tooltips (601ef45) by Ilya
Bogdanov
* fix: use colors from theme in menu (bf641bd) by Ilya Bogdanov
* fix: waybar menu bordes is similar to tooltip ones (76e36f5) by Ilya
Bogdanov
* fix: waybar tooltop border-width (49cfc66) by Ilya Bogdanov
* fix: hovered menu item is recpection border-radius (6c6f82c) by Ilya
Bogdanov
* fix: correct relative paths for language badge links (a695281) by
raphael
* docs: translate keybinds section to Portuguese (pt-BR) (dc0d101) by
raphael
* docs: translate keybinds section to Portuguese (pt-BR) (f2bc18c) by
raphael
* docs: translate keybinds section to Portuguese (pt-BR) and fix distros
logo (f5d057e) by raphael
* docs: translate keybinds section to Portuguese (pt-BR) (97e7db3) by
raphael
---

Please review the changes carefully before merging.
This is an automated PR to promote changes from `rc` to `master`.
Please review and test before merging.

See [TESTING.md](./TESTING.md) for complete testing instructions.

According to our release policy, this PR is expected to be merged on:
**1st or 3rd Friday of the month**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* chore chore: Release - dev → rc (HyDE-Project#1554) (f8aada3) by Khing
* chore thanks! (f124631) by kRHYME7
* chore Merge branch 'rc' into dev (c79a476) by Khing
* docs: translate documentation to Portuguese (HyDE-Project#1543) (c7c6189) by
Khing
* chore Merge branch 'dev' into docs-ptbr (ded3b89) by Khing
* chore More waybar improvements for menus & tooltips (HyDE-Project#1549) (0fb2228)
by Khing
* chore Avoid setting font hinting to full to fallback to default:
slight (7ceff6a) by kRHYME7
* chore Avoid setting font hinting to full to fallback to default:
slight (bf7cee2) by kRHYME7
* chore Removed stray hyprquery binary (af551c6) by kRHYME7
* feat: add fade animation for menus and tooltips (601ef45) by Ilya
Bogdanov
* fix: use colors from theme in menu (bf641bd) by Ilya Bogdanov
* fix: waybar menu bordes is similar to tooltip ones (76e36f5) by Ilya
Bogdanov
* fix: waybar tooltop border-width (49cfc66) by Ilya Bogdanov
* fix: hovered menu item is recpection border-radius (6c6f82c) by Ilya
Bogdanov
* chore Merge branch 'dev' into rc (5fe48b0) by kRHYME7
* fix: correct relative paths for language badge links (a695281) by
raphael
* chore Waybar improvements for menus & popups (HyDE-Project#1542) (b3f7543) by
Khing
* docs: translate keybinds section to Portuguese (pt-BR) (dc0d101) by
raphael
* docs: translate keybinds section to Portuguese (pt-BR) (f2bc18c) by
raphael
* docs: translate keybinds section to Portuguese (pt-BR) and fix distros
logo (f5d057e) by raphael
* docs: translate keybinds section to Portuguese (pt-BR) (97e7db3) by
raphael
* docs: translate keybinds section to Portuguese (pt-BR) (b3b7003) by
raphael
* fix: border-radius applied to menus and tooltips (c257ab3) by Ilya
Bogdanov
* fix: tray checkboxes & radios shape (b7e45ef) by Ilya Bogdanov
---

Please review the changes carefully before merging.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

The environment variable setup block in the Hyprland configuration file is relocated from an earlier position to just before the SCREEN_SHADER_COMPILED block. The env.conf source line and surrounding blank lines are adjusted accordingly, with no changes to other configuration sources.

Changes

Cohort / File(s) Summary
Configuration reorganization
Configs/.local/share/hyde/hyprland.conf
Relocates env.conf source block to a later position in the file, placing it before the SCREEN_SHADER_COMPILED section; blank line spacing adjusted accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Ah, a shuffle of lines in the config's embrace,
Moving env.conf to its rightful place!
Before the shader compiles with care,
The variables settle with rabbit's flair. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix variable expansion' is directly related to the PR's main objective of fixing variable expansion of $srcPath in the hyprland.conf file, making it clear and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jan 21, 2026

@RanMd I remembered something.

try setting this

export HYPRLAND_CONFIG=~/.local/share/hypr/hyprland.conf as your environment variable not terminal. Assuming you don't have the same shell configs as HyDE

I assumed that you have a custom zsh/fish shell or your shell lacks the env variables.https://github.com/HyDE-Project/HyDE/blob/master/Configs%2F.config%2Fzsh%2Fconf.d%2Fhyde%2Fenv.zsh#L47

@RanMd
Copy link
Contributor Author

RanMd commented Jan 21, 2026

I already put it in my .zshenv and nothing changed. I also deleted the fallback file located in ~/.config/hypr/hyprland.conf, and in that case, neither the wallpaper nor the waybar loads.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants